Hello, Dr. David Alan Gilbert, on jeu. 23 févr. 2017 11:40:45 +0000, wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: > > IOW if we transmit this data on the wire, we've effectively said that > > our migration data format is *not* portable across different host OS > > platforms. At that point, sending different sized types on BSD vs > > Linux is no big deal since we're already incompatible semantically. > > This is a relatively recent error; it comes from eae303ff which added > ss_family to allow IPv6. > > I suspect the right fix here is to populate a temporary for ss_family > on the wire; if we make it conveniently match Linux's AF_INET6 values > it might work.
So this issue is actually not new, so I asked to pull your patch series, thanks! Now we should indeed fix the issue. Making the values match Linux' AF_INET6, why not (better have some known values than arbitrary values), but I don't think we'd want to rely on this: we'll have to introduce a versioned difference, since we'll want to change the size of the field as well as its value on other OSes (and I don't think we want to manage different versioning on different OSes). Samuel