Eric Blake <ebl...@redhat.com> writes: > On 02/26/2017 03:43 PM, Markus Armbruster wrote: >> The split between tests/test-qobject-input-visitor.c and >> tests/test-qobject-input-strict.c now makes less sense than ever. The >> next commit will take care of that. >> >> Signed-off-by: Markus Armbruster <arm...@redhat.com> >> --- > > If I read Paolo's thread correctly, we were deferring his patches that > relied on a non-strict visit until 2.10. And we can re-add non-strict > via a new constructor, rather than adding back a bool parameter to all > existing callers, so it doesn't hurt too badly that we are doing this > now for 2.9 (or a revert always works, if it is justified).
Yup. > Reviewed-by: Eric Blake <ebl...@redhat.com> > > >> @@ -276,7 +269,6 @@ static GenericList *qobject_input_next_list(Visitor *v, >> GenericList *tail, >> return tail->next; >> } >> >> - >> static void qobject_input_start_alternate(Visitor *v, const char *name, >> GenericAlternate **obj, size_t >> size, >> bool promote_int, Error **errp) > > Spurious hunk? Yes, will drop. Thanks!