On 03/02/2017 03:44 PM, Markus Armbruster wrote: > As its documentation says, it's not specific to Gluster. Rename it, > as I'm going to use it for something else. > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > block/gluster.c | 38 +++++++++++++++++++------------------- > qapi-schema.json | 38 ++++++++++++++++++++++++++++++++++++++ > qapi/block-core.json | 46 +--------------------------------------------- > 3 files changed, 58 insertions(+), 64 deletions(-)
Mostly mechanical once you deal with the cross-file motion. Changing the type name has no impact on the wire representation, so it's safe. Reviewed-by: Eric Blake <ebl...@redhat.com> > +++ b/qapi-schema.json > @@ -4101,6 +4101,44 @@ > 'fd': 'String' } } > > ## > +# @SocketAddressFlatType: > +# > +# Available SocketAddressFlat types > +# > +# @tcp: Internet address > +# > +# @unix: Unix domain socket > +# > +# Since: 2.9 I probably would have listed 'since: 2.7', since the type is unchanged from its pre-move location... > +# > +# Since: 2.9 > +## > +{ 'union': 'SocketAddressFlat', and again > +++ b/qapi/block-core.json > @@ -2533,50 +2533,6 @@ > '*read-pattern': 'QuorumReadPattern' } } > > ## > -# @GlusterTransport: > -# > -# An enumeration of Gluster transport types > -# > -# @tcp: TCP - Transmission Control Protocol > -# > -# @unix: UNIX - Unix domain socket > -# > -# Since: 2.7 ...here. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature