On 03/02/2017 03:44 PM, Markus Armbruster wrote: > QAPI type SocketAddressFlat differs from SocketAddress pointlessly: > the discriminator value for variant InetSocketAddress is 'tcp' instead > of 'inet'. Rename. > > The type is far only used by the Gluster block drivers. Take care to > keep 'tcp' working there.
The old name was visible in QMP in 2.8, but only by blockdev-add, which we've already argued was not stable (and where we've already made other non-back-compat changes to it). But that means this HAS to go into 2.9, if we're declaring blockdev-add stable for 2.9. It wouldn't hurt to mention that additional information in the commit message. > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > block/gluster.c | 59 > +++++++++++++++++++++++++++++--------------------------- > qapi-schema.json | 8 ++++---- > 2 files changed, 35 insertions(+), 32 deletions(-) > > +++ b/qapi-schema.json > @@ -4105,14 +4105,14 @@ > # > # Available SocketAddressFlat types > # > -# @tcp: Internet address > +# @inet: Internet address > # > # @unix: Unix domain socket Nit: Spacing is now inconsistent. Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
