Eric Blake <ebl...@redhat.com> wrote: > On 04/17/2017 03:00 PM, Juan Quintela wrote: >> This two capabilites were added through the command line. Notice that > > s/This/These/ > s/capabilites/capabilities/ > >> we just created them. This is just the boilerplate. >> >> Signed-off-by: Juan Quintela <quint...@redhat.com> >> --- >> include/migration/migration.h | 3 +++ >> migration/migration.c | 36 ++++++++++++++++++++++++++++++++++++ >> qapi-schema.json | 7 ++++++- >> 3 files changed, 45 insertions(+), 1 deletion(-) > > I think this is a nice cleanup, even if it is exposing the internal > block migration (the 'migrate -b' stuff) that we really don't like (it > is one of the things causing grief at the 2.9-rc4 stage), because users > should be favoring NBD migration over internal block migration these days.
I am 1st in the queue to remove it, but each time that we talk about removing it, somebody appears to came to fix it :-p So, if it has to stay, just update it with the times. > Reviewed-by: Eric Blake <ebl...@redhat.com>
