On 17/04/2017 22:00, Juan Quintela wrote: > Signed-off-by: Juan Quintela <quint...@redhat.com> > --- > include/migration/exec.h | 20 ++++++++++++++++++++
Good cleanup, but please move it to migration/exec.h and include it with "exec.h". This is the standard for files that are not needed outside that particular directory. Paolo > include/migration/migration.h | 4 ---- > migration/exec.c | 2 +- > migration/migration.c | 1 + > 4 files changed, 22 insertions(+), 5 deletions(-) > create mode 100644 include/migration/exec.h > > diff --git a/include/migration/exec.h b/include/migration/exec.h > new file mode 100644 > index 0000000..c97a7e9 > --- /dev/null > +++ b/include/migration/exec.h > @@ -0,0 +1,20 @@ > +/* > + * QEMU live migration exec functions > + * > + * Copyright IBM, Corp. 2008 > + * > + * Authors: > + * Anthony Liguori <aligu...@us.ibm.com> > + * > + * This work is licensed under the terms of the GNU GPL, version 2. See > + * the COPYING file in the top-level directory. > + * > + */ > + > +#ifndef QEMU_MIGRATION_EXEC_H > +#define QEMU_MIGRATION_EXEC_H > +void exec_start_incoming_migration(const char *host_port, Error **errp); > + > +void exec_start_outgoing_migration(MigrationState *s, const char *host_port, > + Error **errp); > +#endif > diff --git a/include/migration/migration.h b/include/migration/migration.h > index 3f54a7c..eb0150b 100644 > --- a/include/migration/migration.h > +++ b/include/migration/migration.h > @@ -194,10 +194,6 @@ void migration_tls_channel_connect(MigrationState *s, > > uint64_t migrate_max_downtime(void); > > -void exec_start_incoming_migration(const char *host_port, Error **errp); > - > -void exec_start_outgoing_migration(MigrationState *s, const char *host_port, > Error **errp); > - > void tcp_start_incoming_migration(const char *host_port, Error **errp); > > void tcp_start_outgoing_migration(MigrationState *s, const char *host_port, > Error **errp); > diff --git a/migration/exec.c b/migration/exec.c > index 2779c9c..1a2d5c2 100644 > --- a/migration/exec.c > +++ b/migration/exec.c > @@ -21,7 +21,7 @@ > #include "qapi/error.h" > #include "qemu-common.h" > #include "migration/channel.h" > -#include "migration/migration.h" > +#include "migration/exec.h" > #include "io/channel-command.h" > #include "trace.h" > > diff --git a/migration/migration.c b/migration/migration.c > index 17d22eb..076c42a 100644 > --- a/migration/migration.c > +++ b/migration/migration.c > @@ -21,6 +21,7 @@ > #include "migration/machine.h" > #include "migration/state.h" > #include "migration/init.h" > +#include "migration/exec.h" > #include "migration/migration.h" > #include "migration/qemu-file.h" > #include "sysemu/sysemu.h" >