Stefan Hajnoczi <stefa...@redhat.com> writes: > On Fri, Apr 28, 2017 at 10:33:36AM +0200, Markus Armbruster wrote: >> Eric Blake <ebl...@redhat.com> writes: >> >> > We now have macros in place to make it less verbose to add a scalar >> > to QDict and QList, so use them. To make this patch smaller to >> > review, a couple of subdirectories were done in earlier patches. >> >> Scratch the last sentence. Can do on commit. >> >> > Patch created mechanically via: >> > spatch --sp-file scripts/coccinelle/qobject.cocci \ >> > --macro-file scripts/cocci-macro-file.h --dir . --in-place >> > then touched up manually to fix a couple of '?:' back to original >> > spacing, as well as avoiding a long line in monitor.c. >> > >> > Signed-off-by: Eric Blake <ebl...@redhat.com> >> > Reviewed-by: Markus Armbruster <arm...@redhat.com> >> > >> > --- >> > v5: rebase to master (Coccinelle found a couple new spots), squash 3 >> > patches into 1, adjust R-b to only list Markus (while there were other >> > reviews on the pre-squashed patches, Markus was the only one on all 3) >> >> The block: part had >> >> Acked-by: Richard W.M. Jones <rjo...@redhat.com> >> Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> >> Reviewed-by: Alberto Garcia <be...@igalia.com> >> >> The tests and qobject parts had >> >> Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> >> >> Richard, Stefan, Alberto, Philippe, let me know if you'd like me to >> convert your R-by of parts to an Acked-by of the combined patch. Feel >> free to review the combined patch, of course. > > Please keep my R-by, I have reviewed again.
Gladly. Thanks!
