On Tue, Oct 26, 2010 at 08:25:14AM -0500, Anthony Liguori wrote: > On 10/26/2010 05:48 AM, Gleb Natapov wrote: > >Store all io ports used by device in ISADevice structure. > > > >Signed-off-by: Gleb Natapov<g...@redhat.com> > >--- > > hw/cs4231a.c | 1 + > > hw/fdc.c | 3 +++ > > hw/gus.c | 4 ++++ > > hw/ide/isa.c | 2 ++ > > hw/isa-bus.c | 25 +++++++++++++++++++++++++ > > hw/isa.h | 4 ++++ > > hw/m48t59.c | 1 + > > hw/mc146818rtc.c | 1 + > > hw/ne2000-isa.c | 3 +++ > > hw/parallel.c | 5 +++++ > > hw/pckbd.c | 3 +++ > > hw/sb16.c | 4 ++++ > > hw/serial.c | 1 + > > 13 files changed, 57 insertions(+), 0 deletions(-) > > > >diff --git a/hw/cs4231a.c b/hw/cs4231a.c > >index 4d5ce5c..598f032 100644 > >--- a/hw/cs4231a.c > >+++ b/hw/cs4231a.c > >@@ -645,6 +645,7 @@ static int cs4231a_initfn (ISADevice *dev) > > isa_init_irq (dev,&s->pic, s->irq); > > > > for (i = 0; i< 4; i++) { > >+ isa_init_ioport(dev, i); > > register_ioport_write (s->port + i, 1, 1, cs_write, s); > > register_ioport_read (s->port + i, 1, 1, cs_read, s); > > A better way to do this would be to introduce isa_register_ioport. >
That what Markus proposed and, in principal, I agree. I would like to keep that out from this path series, but if it is not a big churn and maintainers insists I can look at it. I need to do something anyway while Markus is cooling down :) > We can take Avi's series first since that probably makes this easier > to implement. > It is ready to go in, no? -- Gleb.