On Tue, Oct 26, 2010 at 10:48 AM, Gleb Natapov <g...@redhat.com> wrote:
> Store all io ports used by device in ISADevice structure.
>
> Signed-off-by: Gleb Natapov <g...@redhat.com>
> ---
> hw/cs4231a.c | 1 +
> hw/fdc.c | 3 +++
> hw/gus.c | 4 ++++
> hw/ide/isa.c | 2 ++
> hw/isa-bus.c | 25 +++++++++++++++++++++++++
> hw/isa.h | 4 ++++
> hw/m48t59.c | 1 +
> hw/mc146818rtc.c | 1 +
> hw/ne2000-isa.c | 3 +++
> hw/parallel.c | 5 +++++
> hw/pckbd.c | 3 +++
> hw/sb16.c | 4 ++++
> hw/serial.c | 1 +
> 13 files changed, 57 insertions(+), 0 deletions(-)
>
> diff --git a/hw/cs4231a.c b/hw/cs4231a.c
> index 4d5ce5c..598f032 100644
> --- a/hw/cs4231a.c
> +++ b/hw/cs4231a.c
> @@ -645,6 +645,7 @@ static int cs4231a_initfn (ISADevice *dev)
> isa_init_irq (dev, &s->pic, s->irq);
>
> for (i = 0; i < 4; i++) {
> + isa_init_ioport(dev, i);
> register_ioport_write (s->port + i, 1, 1, cs_write, s);
> register_ioport_read (s->port + i, 1, 1, cs_read, s);
I'd prefer a system where the also register_ioport_xxx (or even its
handle-returning equivalent) would be done by isa-bus.c (or pci.c).
Though maybe we could think of your patch as the first step.
