On 29/04/17 11:49, xiaoqiang zhao wrote: > This patch set aims for QOM'ifying code relate with sparc. > It is part of my QOM'ify work of qemu code base. > > changes since v1: > * rebased on the latest master > > xiaoqiang zhao (9): > hw/misc: QOM'ify eccmemctl.c > hw/dma: QOM'ify sparc32_dma.c > hw/dma: QOM'ify sun4m_iommu.c > hw/misc: QOM'ify slavio_misc.c > hw/timer: QOM'ify m48txx_sysbus (pass 1) > hw/timer: QOM'ify m48txx_sysbus (pass 2) > hw/timer: QOM'ify slavio_timer > hw/sparc: QOM'ify sun4m.c > hw/sparc64: QOM'ify sun4u.c > > hw/dma/sparc32_dma.c | 25 ++++++++++++++--------- > hw/dma/sun4m_iommu.c | 12 +++++------ > hw/misc/eccmemctl.c | 25 ++++++++++++++--------- > hw/misc/slavio_misc.c | 43 ++++++++++++++++----------------------- > hw/sparc/sun4m.c | 54 > +++++++++++++++++-------------------------------- > hw/sparc64/sun4u.c | 20 +++++++++--------- > hw/timer/m48t59.c | 38 +++++++++++++++++----------------- > hw/timer/slavio_timer.c | 12 +++++------ > 8 files changed, 105 insertions(+), 124 deletions(-)
I've finally found time to take a look at these and they look good to me. I'll wait a few days to see if anyone has any comments (particularly relating to the m48t59 device since that it appears that device is also used by PReP) but if I hear nothing then I'll apply to my qemu-sparc branch. And please do accept my apologies that it has taken so long to review these patches, I will aspire to do much better in future. ATB, Mark.