On 23.05.2017 17:54, Richard Henderson wrote: > On 05/23/2017 03:48 AM, Aurelien Jarno wrote: >> On 2017-05-22 20:02, Richard Henderson wrote: >>> Previously, helper_ex would construct the insn and then implement >>> the insn via direct calls other helpers. This was sufficient to >>> boot Linux but that is all. >>> >>> It is easy enough to go the whole nine yards by stashing state for >>> EXECUTE within the cpu, and then relying on a new TB to be created >>> that properly and completely interprets the insn. >>> >>> Signed-off-by: Richard Henderson <r...@twiddle.net> >>> --- >>> target/s390x/cpu.h | 4 +- >>> target/s390x/helper.h | 2 +- >>> target/s390x/insn-data.def | 4 +- >>> target/s390x/machine.c | 19 +++++++ >>> target/s390x/mem_helper.c | 136 >>> +++++++++++---------------------------------- >>> target/s390x/translate.c | 124 >>> +++++++++++++++++++++++++---------------- >>> 6 files changed, 133 insertions(+), 156 deletions(-) >> >> This looks good on the principle, and finally removes a big hack. That >> said it prevent my test system to boot. I haven't investigated why yet. > > Hmm. I've not got a complete environment -- merely booting a kernel up > to the point it fails to find a rootfs. Which did find several problems > with my first attempts at this, but wouldn't have exercised paging. > I'll try again to get a full install working...
Something nice for a quick test is also: http://www.qemu-advent-calendar.org/2014/download/s390-moon-buggy.tar.xz Not sure whether it will trigger your EXECUTE problem, though. Thomas