On Thu, May 18, 2017 at 4:58 PM Markus Armbruster <arm...@redhat.com> wrote:

> Marc-André Lureau <marcandre.lur...@redhat.com> writes:
>
> > Use a more specific bool type.
> >
> > Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com>
>
> Why doesn't this run afoul backward compatibility?  To answer the
> question, we need to enumerate affected external interfaces.
>
>
Right, this will break if we have users such as:

 -global PIIX4_PM.disable_s3=2

With this change, it will now error with:

qemu-system-x86_64: can't apply global PIIX4_PM.disable_s3=2: Invalid
parameter type for 'disable_s3', expected: boolean

Acceptable? otherwise, I drop the patch

thanks
-- 
Marc-André Lureau

Reply via email to