On Thu, Jun 01, 2017 at 10:56:50AM -0500, Michael Roth wrote: > Quoting David Gibson (2017-05-31 20:52:15) > > Currently implementations of the RTAS calls related to DRCs are in > > spapr_rtas.c. They belong better in spapr_drc.c - that way they're closer > > to related code, and we'll be able to make some more things local. > > > > spapr_rtas.c was intended to contain the RTAS infrastructure and core calls > > that don't belong anywhere else, not every RTAS implementation. > > > > Code motion only. > > Technically rtas-get-sensor-state and rtas-set-indicator aren't specific > to DRCs, but looking through the documented indicators/sensors (tables > 40 and 42 in LoPAPR v11) it doesn't seem too likely we'll ever implement > any others so the move seems reasonable.
True, I realised that a little after I posted.
Even if we did implement other sensors, though, the natural way to
split this would be to have the generic set-indicator function check
simply that the indicator is a DR related one, and pass the options
straight to a function in the DRC code, rather doing preliminary
looking into DRC internals as it does now.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
