On Thu, Jun 01, 2017 at 08:55:19PM -0700, no-re...@patchew.org wrote: > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Type: series > Message-id: 20170602031507.29881-1-da...@gibson.dropbear.id.au > Subject: [Qemu-devel] [PATCHv5 0/4] Clean up compatibility mode handling > > === TEST SCRIPT BEGIN === > #!/bin/bash > > BASE=base > n=1 > total=$(git log --oneline $BASE.. | wc -l) > failed=0 > > git config --local diff.renamelimit 0 > git config --local diff.renames True > > commits="$(git log --format=%H --reverse $BASE..)" > for c in $commits; do > echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." > if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; > then > failed=1 > echo > fi > n=$((n+1)) > done > > exit $failed > === TEST SCRIPT END === > > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > Switched to a new branch 'test' > 6ccf47f ppc: Rework CPU compatibility testing across migration > 2b75df3 pseries: Reset CPU compatibility mode > 282a89c pseries: Move CPU compatibility property to machine > 8741a73 qapi: add explicit null to string input and output visitors > > === OUTPUT BEGIN === > Checking PATCH 1/4: qapi: add explicit null to string input and output > visitors... > Checking PATCH 2/4: pseries: Move CPU compatibility property to machine... > Checking PATCH 3/4: pseries: Reset CPU compatibility mode... > Checking PATCH 4/4: ppc: Rework CPU compatibility testing across migration... > ERROR: braces {} are necessary for all arms of this statement > #94: FILE: target/ppc/machine.c:236: > + if (cpu->compat_pvr) { > [...] > + } else > [...] > > total: 1 errors, 0 warnings, 100 lines checked
This is a false positive triggered by an #ifdef intersecting the if/else. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature