On Fri, Jun 09, 2017 at 03:55:56PM +0200, Greg Kurz wrote: > On Fri, 2 Jun 2017 13:15:05 +1000 > David Gibson <da...@gibson.dropbear.id.au> wrote: > > > Server class POWER CPUs have a "compat" property, which is used to set the > > backwards compatibility mode for the processor. However, this only makes > > sense for machine types which don't give the guest access to hypervisor > > privilege - otherwise the compatibility level is under the guest's control. > > > > To reflect this, this removes the CPU 'compat' property and instead > > creates a 'max-cpu-compat' property on the pseries machine. Strictly > > speaking this breaks compatibility, but AFAIK the 'compat' option was > > never (directly) used with -device or device_add. > > > > The option was used with -cpu. So, to maintain compatibility, this > > patch adds a hack to the cpu option parsing to strip out any compat > > options supplied with -cpu and set them on the machine property > > instead of the now deprecated cpu property. > > > > Signed-off-by: David Gibson <da...@gibson.dropbear.id.au> > > --- > > Just one trivial style nit in ppc_compat_prop_set(). > > Reviewed-by: Greg Kurz <gr...@kaod.org> > > and > > Tested-by: Greg Kurz <gr...@kaod.org>
Thanks.
[snip]
> > +static void ppc_compat_prop_set(Object *obj, Visitor *v, const char *name,
> > + void *opaque, Error **errp)
> > +{
> > + Error *error = NULL;
>
> s/error/local_error maybe ? For consistency with ppc_compat_add_property()
> below.
Yeah, makes sense. local_err does seem to be by far the more common
name for this idiom.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
