Marc-André Lureau <marcandre.lur...@redhat.com> writes:
> e->size is hwaddr, i.e. uint64_t. We silently truncate.
> Fix suggested by Markus Armbruster.
I'd prefer
Suggested-by: Markus Armbruster <arm...@redhat.com>
> Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com>
> ---
> hw/pci-host/q35.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c
> index cd5c49616e..e8a04d31d1 100644
> --- a/hw/pci-host/q35.c
> +++ b/hw/pci-host/q35.c
> @@ -129,9 +129,8 @@ static void q35_host_get_mmcfg_size(Object *obj, Visitor
> *v, const char *name,
> void *opaque, Error **errp)
> {
> PCIExpressHost *e = PCIE_HOST_BRIDGE(obj);
> - uint32_t value = e->size;
>
> - visit_type_uint32(v, name, &value, errp);
> + visit_type_uint64(v, name, &e->size, errp);
> }
>
> static Property mch_props[] = {
Reviewed-by: Markus Armbruster <arm...@redhat.com>
