Marc-André Lureau <marcandre.lur...@gmail.com> writes: > On Fri, Jun 2, 2017 at 6:00 PM Marc-André Lureau <marcandre.lur...@gmail.com> > wrote: > >> On Fri, Jun 2, 2017 at 5:55 PM Markus Armbruster <arm...@redhat.com> >> wrote: >> >>> Marc-André Lureau <marcandre.lur...@redhat.com> writes: >>> >>> > Add and use unsigned type for various properties. >>> > >>> > Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> >>> >>> The commit message is a bit misleading. We don't "add unsigned >>> properties", we clean up the property code to avoid type casts between >>> signed and unsigned. >>> >> >> That in itself is imho a good reason for the cleanup :)
I could accept that with a commit message that says so :) > There might be other reason, as if a value is stored as negative QNum/i64 > after cast, and later retrieve with get_uint(), it will fail. I see. >>> I'm not sure that's worth the churn by itself. But perhaps it helps >>> later in this series. If yes, can you give me a hint? >>> >> >> Churn is quite minimal though.
