On Sun, Jun 25, 2017 at 12:03:56 +0300, Lluís Vilanova wrote:
> Temporarily redefine DISAS_* values based on DJ_TARGET. They should
> disappear as targets get ported to the generic framework.
> 
> Signed-off-by: Lluís Vilanova <vilan...@ac.upc.edu>
> Acked-by: David Gibson <da...@gibson.dropbear.id.au> (ppc)
> Acked-by: Eduardo Habkost <ehabk...@redhat.com>
> Reviewed-by: Eduardo Habkost <ehabk...@redhat.com> (i386)
> Acked-by: Laurent Vivier <laur...@vivier.eu> (m68k)
> Reviewed-by: Alex Benée <alex.be...@linaro.org> (arm)

Why don't we just keep DISAS_* instead? That will simplify diffs (i.e.
no need to eventually convert anything to DJ_*), and really DISAS_NEXT
makes more sense than DJ_NEXT. You can define a few generic DISAS_foo's,
plus DISAS_TARGET that the existing DISAS_* can build from.

Also, IMO DJ is a poor choice for an acronym. Am I the only one
immediately thinking of 'disc jockey'? =)

                E.

Reply via email to