On Wed, Jun 28, 2017 at 14:23:07 +0300, Lluís Vilanova wrote: > Emilio G Cota writes: > > > On Sun, Jun 25, 2017 at 12:07:57 +0300, Lluís Vilanova wrote: > >> Incrementally paves the way towards using the generic instruction > >> translation > >> loop. > >> > >> Signed-off-by: Lluís Vilanova <vilan...@ac.upc.edu> > > > Just a minor nit: the commit titles are a little strange to me. > > I'd rather do: "target/arch: foo" than "target: [tcg, arch]: foo" -- > > it's less characters ("tcg" is redundant) and seems more in line with > > qemu's idioms. > > Is tcg redundant? I thought it was necessary for differentiating it from the > kvm > target-specific parts.
In most cases it is redundant -- anyway my point is that "targer/foo" will be enough to get the right eyes on the patch. Cheers, E.