Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> writes: > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> > --- > block/dirty-bitmap.c | 5 +++++ > blockdev.c | 25 +++++++++++++++++++++++++ > include/block/dirty-bitmap.h | 1 + > include/qemu/hbitmap.h | 8 ++++++++ > qapi/block-core.json | 27 +++++++++++++++++++++++++++ > tests/Makefile.include | 2 +- > util/hbitmap.c | 11 +++++++++++ > 7 files changed, 78 insertions(+), 1 deletion(-) [...] > diff --git a/qapi/block-core.json b/qapi/block-core.json > index 5c42cc7790..6ad8585400 100644 > --- a/qapi/block-core.json > +++ b/qapi/block-core.json > @@ -1644,6 +1644,33 @@ > 'data': 'BlockDirtyBitmap' } > > ## > +# @BlockDirtyBitmapSha256: > +# > +# SHA256 hash of dirty bitmap data > +# > +# @sha256: ASCII representation of SHA256 bitmap hash
Spell it SHA-256, please. The member name @sha256 can stay. SHA-256 is 256 binary bits. Please specify how they are represented in ASCII. It better be base64 (RFC 4648), because we use that elsewhere. > +# > +# Since: 2.10 > +## > + { 'struct': 'BlockDirtyBitmapSha256', > + 'data': {'sha256': 'str'} } > + > +## > +# @x-debug-block-dirty-bitmap-sha256: > +# > +# Get bitmap SHA256 > +# > +# Returns: BlockDirtyBitmapSha256 on success > +# If @node is not a valid block device, DeviceNotFound > +# If @name is not found or if hashing has failed, GenericError with > an > +# explanation Please wrap your comment lines around column 70. > +# > +# Since: 2.10 > +## > + { 'command': 'x-debug-block-dirty-bitmap-sha256', > + 'data': 'BlockDirtyBitmap', 'returns': 'BlockDirtyBitmapSha256' } > + > +## > # @blockdev-mirror: > # > # Start mirroring a block device's writes to a new destination. [...]