On Fri, Jul 07, 2017 at 10:05:22AM +0200, Markus Armbruster wrote: > Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> writes: > > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> > > --- > > block/dirty-bitmap.c | 5 +++++ > > blockdev.c | 25 +++++++++++++++++++++++++ > > include/block/dirty-bitmap.h | 1 + > > include/qemu/hbitmap.h | 8 ++++++++ > > qapi/block-core.json | 27 +++++++++++++++++++++++++++ > > tests/Makefile.include | 2 +- > > util/hbitmap.c | 11 +++++++++++ > > 7 files changed, 78 insertions(+), 1 deletion(-) > [...] > > diff --git a/qapi/block-core.json b/qapi/block-core.json > > index 5c42cc7790..6ad8585400 100644 > > --- a/qapi/block-core.json > > +++ b/qapi/block-core.json > > @@ -1644,6 +1644,33 @@ > > 'data': 'BlockDirtyBitmap' } > > > > ## > > +# @BlockDirtyBitmapSha256: > > +# > > +# SHA256 hash of dirty bitmap data > > +# > > +# @sha256: ASCII representation of SHA256 bitmap hash > > Spell it SHA-256, please. The member name @sha256 can stay. > > SHA-256 is 256 binary bits. Please specify how they are represented in > ASCII. It better be base64 (RFC 4648), because we use that elsewhere.
It is filled later in this patch using qcrypto_hash_digest, so it is just a hex string representing the hash, not base64. For the latter you can use qcrypto_hash_base64 Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
