On Tue, Jul 25, 2017 at 04:15:14PM -0500, Eric Blake wrote: > We have two flavors of vararg usage in qtest; make it clear that > qmp() has different semantics than hmp(), and let the compiler > enforce that hmp() is used correctly. However, qmp() (and friends) > only accept a subset of printf flags look-alikes (namely, those > that our JSON parser understands), and what is worse, qmp("true") > (the JSON keyword 'true') is different from qmp("%s", "true") > (the JSON string '"true"'), and we have some intermediate cleanup > patches to do before we can mark those as printf-like. > > Signed-off-by: Eric Blake <ebl...@redhat.com> > > --- > v3: restore lost attributes, add comments on va_list forms, tweak > commit message to mention upcoming qmp cleanups > v2: several comment tweaks, explain why qmp() can't be marked > --- > tests/libqtest.h | 40 +++++++++++++++++++++++++--------------- > 1 file changed, 25 insertions(+), 15 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
signature.asc
Description: PGP signature