Eric Blake <ebl...@redhat.com> writes: > On 07/28/2017 11:35 AM, Eric Blake wrote: >>>> + QObject *extra_args = qobject_from_jsonf("{ 'shm': '%s', 'size': '1M' >>>> }", >>>> + tmpshm); >>> > >> Passing '%s' through qobject_from_jsonf() is generally wrong (it would >> produce ''...'' instead of the intended '...'). >> >> Looks like something to fix on the next round. >> > > What's scary is that the testsuite didn't start failing. That's not > good; we'll want to figure out why the bug didn't impact the test.
Good idea.