On 07/28/2017 11:35 AM, Eric Blake wrote:
>>> + QObject *extra_args = qobject_from_jsonf("{ 'shm': '%s', 'size': '1M'
>>> }",
>>> + tmpshm);
>>> Passing '%s' through qobject_from_jsonf() is generally wrong (it would > produce ''...'' instead of the intended '...'). > > Looks like something to fix on the next round. > What's scary is that the testsuite didn't start failing. That's not good; we'll want to figure out why the bug didn't impact the test. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
