On 08/18/2017 05:15 PM, Eric Blake wrote: > libqtest provides two layers of functions: qtest_*() that operate > on an explicit object, and a plain version that operates on the > 'global_qtest' object. However, very few tests care about the > distinction, and even the tests that manipulate multiple qtest > connections at once are just fine reassigning global_qtest around > the blocks of code that will then operate on the updated global, > rather than calling the verbose form. Before the next few patches > get rid of the qtest_* layer, we first need to update the remaining > few spots that were using the long form where we can instead rely > on the short form. >
Not a big fan of globals and implicit state, but I do at least agree that we don't need two sets of functions. (You just happen to be killing the set I like.) eh, to-may-to to-mah-to. > Signed-off-by: Eric Blake <ebl...@redhat.com> Acked-by: John Snow <js...@redhat.com>
