On 08/19/2017 11:34 AM, Paolo Bonzini wrote: > On 18/08/2017 23:33, John Snow wrote: >>> Before the next few patches >>> get rid of the qtest_* layer, we first need to update the remaining >>> few spots that were using the long form where we can instead rely >>> on the short form. >>> >> Not a big fan of globals and implicit state, but I do at least agree >> that we don't need two sets of functions. > > I agree with using the short form where possible, but I disagree on > removing the long forms. Rather, global_qtest in my opinion should have > been static (though I'm not proposing that you do this); inlining the > wrappers is not needed for performance.
But no one outside of libqtest.c is using the long form. Maintaining a long form that isn't used is counter-productive, if the short form is good enough for everything we need. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
