On 21.08.2017 11:52, Cornelia Huck wrote: > On Fri, 18 Aug 2017 19:28:34 +0200 > David Hildenbrand <da...@redhat.com> wrote: > >> On 18.08.2017 18:08, Thomas Huth wrote: >>> On 18.08.2017 13:43, David Hildenbrand wrote: >>>> s390-stattrib.c needs definition of TARGET_PAGE_SIZE, solve it via cpu.h. >>> >>> Why not simply #include "exec/cpu-all.h" ? If cpu.h is not really needed >>> here... >>> >>> Thomas >>> >>> >> >> Git grep showed me that this is a very rare thing to do, so I went for >> cpu.h. If you prefer cpu-all.h, I can use that. > > Is there any target that does not include cpu-all.h in its cpu.h? We > probably can remove all includes of cpu-all.h in .c files, as all of > them include cpu.h as well... >
I guess they have to, otherwise this stuff will not compile. Yes, we should be able to remove exec/cpu-all.h from both remaining users, dump.c and exec.c, as they already include cpu.h as you also noticed. -- Thanks, David
