On Mon, 21 Aug 2017 13:05:12 +0200 David Hildenbrand <da...@redhat.com> wrote:
> On 21.08.2017 12:08, Cornelia Huck wrote: > > In s390-virtio.c, the only thing used outside of s390-virtio-ccw.c is > > s390_cpuaddr2state(), and the only place that uses it for something > > other than getting a dummy cpu is the kvm sigp target code. Can we > > replace that last usage with a different construct? > > As CPUs are stored in s390-virtio.c (S390CPU **cpu_states) this is not > possible. We could only get access to cpu #x via qom /machine/cpu[#x], > but I guess that won't have best performance :) > > We could move that definition into the machine state (which would make > sense, as the cpus belong to a machine). The machine state looks like a better place than s390-virtio.c. > > > > > In s390-virtio.h, the s390_register_virtio_hypercall() interface is the > > only thing that still makes sense to be exported. > > > > Anyhow, I would prefer to have these cleanups in a separate series. > Nevertheless they make perfect sense. This is certainly material for a different series :) Just thought I'd write down what I noticed.
