On 11/24/2010 10:04 AM, Kevin Wolf wrote: > Am 24.11.2010 09:57, schrieb Hannes Reinecke: >> On 11/24/2010 09:18 AM, Nicholas A. Bellinger wrote: >>> From: Nicholas Bellinger <n...@linux-iscsi.org> >>> >>> This patch adds a handful of bugfixes for scsi-generic >>> that where added into: >>> >>> commit a4194b3f79a85e111f000788ddec05d465748851 >>> Author: Hannes Reinecke <h...@suse.de> >>> Date: Mon Nov 22 15:39:33 2010 -0800 >>> >>> scsi: Use 'SCSIRequest' directly >>> >>> this includes: >>> >>> *) Fix incorrect errno usage in switch() statement within >>> scsi_command_complete() >>> >>> *) Remove bogus scsi_command_complete() for residual case >>> within scsi_read_complete() >>> >>> *) Remove incorrect '-' sign from return in scsi_send_command() >>> >>> Tested with .37-rc2 TCM_Loop FILEIO backstores on KVM host into >>> Debian Lenny v2.6.26 KVM guest with an xfs filesystem mount. >>> >>> Signed-off-by: Nicholas A. Bellinger n...@linux-iscsi.org> > > Hannes, can you fold the necessary parts of this into the next version > of your series, so that we don't break things first and fix them only later? > I'll be folding the first one into my series.
The second one is actually a genuine error, and a rather old one to boot. It went in with this commit: commit 89c0f6438d16ebceccdcd096bbc0b5536146a443 Author: aurel32 <aure...@c046a42c-6fe2-441c-8c8c-71466251a162> Date: Fri Oct 17 08:08:56 2008 +0000 Subject: scsi-generic: correct error management So I'd rather have it submitted separately. And a second opinion is _definitely_ required here. nab, can you do the honours? The third is bogus anyway. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Markus Rex, HRB 16746 (AG Nürnberg)
