On 11/24/2010 11:34 AM, Kevin Wolf wrote: > Am 24.11.2010 11:16, schrieb Hannes Reinecke: >> The second one is actually a genuine error, and a rather old one to >> boot. It went in with this commit: >> >> commit 89c0f6438d16ebceccdcd096bbc0b5536146a443 >> Author: aurel32 <aure...@c046a42c-6fe2-441c-8c8c-71466251a162> >> Date: Fri Oct 17 08:08:56 2008 +0000 >> Subject: scsi-generic: correct error management >> >> So I'd rather have it submitted separately. >> And a second opinion is _definitely_ required here. >> nab, can you do the honours? > > The commit message of this commit says it's a workaround for a problem > with lsi: > >> - when a read is aborted due to a mark/EOF/EOD/EOM, the len reported to >> controller can be 0. LSI controller emulation doesn't know how to manage >> this. A workaround found is to call the completion routine with >> SCSI_REASON_DONE just after calling it with SCSI_REASON_DATA with len=0. > > Are you sure that it's not needed any more? > Don't ask me. I didn't do the patch, and my knowledge of lsi HBA internals is scanty. Nic, can you comment here?
Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Markus Rex, HRB 16746 (AG Nürnberg)
