On Fri, Sep 1, 2017 at 12:21 AM, Paolo Bonzini <pbonz...@redhat.com> wrote:
> Il 31 ago 2017 3:54 PM, "Izik Eidus" <i...@veertu.com> ha scritto: > > > Izik, Vincent (assuming you are the right person to contact at Google), > > can you reply to Daniel and Stefan? > > > > Hi, > > What I suggest is that we will send our patch' again as gpl2+ and clean the > entire stuff to make sure they are falling into the right copyright > category as required by QEMU. > > > That's not necessary. Just you and Vincent replying to this thread with a > "Signed-off-by" line would be enough for Sergio to use the right license in > his v3 submission. Sergio already made some non-trivial changes that are > needed for inclusion in QEMU from a supportability (e.g. dirty page > tracking for graphics) or maintainability perspective (e.g. -cpu support), > so the simplest thing to do is to retrofit the right license to his > submission. You can do so if you can confirm that the code you used only > came from QEMU itself, Bochs or other GPLv2+/LGPL software (and the rest > was written by Veertu). > Hi, I found 2 functions that can't be licensed as GPLv2+ (only GPLv2) they are very insignificant and one of them is never being called, As soon as Sergio reply to me about what I am missing in getting 1/13 and 2/13 patch's to work, I will send 2/13 again acked by me with full GPLv2+ license code (without the GPLv2 code) from Veertu and then Google have to approve as well. Thanks. > > Google has already contributed the HAXN accelerator, so I am moderately > optimistic that they can help with HVF too. > > BTW, another thing that need to be integrated in order to make this stuff > useful is the vmnet patch's, it is apple NAT for vms that allow guests to > have networking... > > > People can always use slirp (or tap with some more effort), so these > patches are already a minimum viable feature and pretty close to being > mergeable. But of course any other contribution is welcome! > > Paolo > > > (altho that it come with a trick, without certificate it > will require root permission, while hypverisor framework itself can run > without root) > > What do you guys think? > > > > > > Sergio worked on completing the QEMU port to Hypervisor.framework. The > > hvf-all.c file that Daniel pointed out as v2-only is derived from > kvm-all.c > > and hax-all.c, and should be under v2-or-later license. The others seem > to > > be either original or derived from Bochs, which is LGPL, so they could be > > LGPL or GPLv2+. > > > > Thanks, > > > > Paolo > > > > > > There are benefits to having this code upstream. If they ever want to > > rebase on qemu.git there will be less work for them. > > > > Stefan > > > > > > > > >