On Wed, Sep 6, 2017 at 5:28 PM, Paolo Bonzini <pbonz...@redhat.com> wrote: > Il 06 set 2017 3:29 PM, "Izik Eidus" <i...@veertu.com> ha scritto: > > Paolo, I was reviewing more and more our code and found another issue > regarding licensing of gpl2v+: the file x86_descr.c include: > #define VMX_SEGMENT_FIELD(seg) that is coming from KVM that is gpl2 code. > > > I don't think that's copyrightable. > > unfortunately we had a developer that introduced both this code and the > task_switch, I am reviewing more and more this now to find if we have any > other gpl2v only in our code. > > Maybe it does worth to reconsider us donating hypervisor.framework > implemantion that will be clean from such gpl2v only issue? I know it will > slow little bit the integration but we are willing to put all the > effort that is needed, including syncing all Sergio later on patch's > and whatever is needed more. > > > I think we need to be pragmatic and picking the best of the two > implementations (plus KVM itself) is the best option. There is considerable > overlap between QEMU and KVM developers, and anyone could say in bad faith > that people are reusing their KVM knowledge when touching HVF code in QEMU. > > What matters more in my non-lawyerly opinion is that we handle HVF code as a > part of QEMU rather than something bolted on the side. This alone will make > a lot of functions that _could_ come from external sources go away, as the > processor emulation stuff from TCG can easily get reused.
OK, fine with me. Thanks. > > Patio > > Paolo > > > Thanks. > >> >> >> Then Izik and Frank can reply with their Signed-off-by to that extra >> patch. >> >> Thanks, >> >> Paolo >> >> >> >> > >> > I think it's safe to use v2+ for this code once Google agrees. The task >> > switch code, which is going to go away soon anyway and is isolated from >> > the >> > rest, can be moved to a separate file for the time being. >> > >> >> >> OK, such case would be simpler to me to go if this what you prefer, in >> such >> case, i will send the 1|2|3 patches splited from task switch and >> everything beside task switch as gpl2v+. >> >> Whatever you guys decide... >> >> Thanks. >> >> >> > >> > Paolo >> > >> > >> > > >> > > Paolo >> > > >> > > in >> > > such case all copyright go back to BSD2 and we can license it as >> > > GPL2v+ >> > or >> > > whatever work for QEMU. >> > > If you want to go in such case what we will do would be the following: >> > > take kvm user space implemantion of qemu that is GPLv2+, integrate to >> > > it >> > > the hypervisor framework from Anka (in kvm user space style) - this >> > > will >> > > put us in hvf [1|2|3 / 13] in safe GPLv2+ and then we can back port >> > > the >> > > rest of Sergio changes to this stuff. >> > > >> > > I know this is less than ideal as it requires some changes to the >> > > current >> > > patch set, however it will make it 100% safe to be GPL2v+, what you >> > > guys >> > > think?, we can get this stuff done before the end of this week... >> > > >> > > Thanks. >> > > >> > > >> > > On Fri, Sep 1, 2017 at 12:39 AM, Izik Eidus <i...@veertu.com >> > <javascript:_e(%7B%7D,'cvml','i...@veertu.com');>> wrote: >> > > >> > > > >> > > > >> > > > On Fri, Sep 1, 2017 at 12:21 AM, Paolo Bonzini <pbonz...@redhat.com >> > <javascript:_e(%7B%7D,'cvml','pbonz...@redhat.com');>> >> > > > wrote: >> > > > >> > > >> Il 31 ago 2017 3:54 PM, "Izik Eidus" <i...@veertu.com >> > <javascript:_e(%7B%7D,'cvml','i...@veertu.com');>> ha scritto: >> >> > > >> >> > > >> > Izik, Vincent (assuming you are the right person to contact at >> > > Google), >> > > >> > can you reply to Daniel and Stefan? >> > > >> > >> > > >> >> > > >> Hi, >> > > >> >> > > >> What I suggest is that we will send our patch' again as gpl2+ and >> > clean >> > > >> the >> > > >> entire stuff to make sure they are falling into the right copyright >> > > >> category as required by QEMU. >> > > >> >> > > >> >> > > >> That's not necessary. Just you and Vincent replying to this thread >> > with >> > > a >> > > >> "Signed-off-by" line would be enough for Sergio to use the right >> > > license in >> > > >> his v3 submission. Sergio already made some non-trivial changes >> > > >> that >> > are >> > > >> needed for inclusion in QEMU from a supportability (e.g. dirty page >> > > >> tracking for graphics) or maintainability perspective (e.g. -cpu >> > > support), >> > > >> so the simplest thing to do is to retrofit the right license to his >> > > >> submission. You can do so if you can confirm that the code you used >> > only >> > > >> came from QEMU itself, Bochs or other GPLv2+/LGPL software (and the >> > rest >> > > >> was written by Veertu). >> > > >> >> > > > >> > > > Hi, >> > > > >> > > > Sure fine with us, let me go over all the code and see that all >> > copyright >> > > > that are needed are there, and then you can relicense all our code >> > > > to >> > > > GPLv2+, I think I saw a a file that was missing Bochs copyright in >> > > > it, >> > > so I >> > > > want to make sure that I fix this before and that all others are >> > > > fine. >> > > > >> > > > Thanks. >> > > > >> > > > >> > > >> >> > > >> Google has already contributed the HAXN accelerator, so I am >> > moderately >> > > >> optimistic that they can help with HVF too. >> > > >> >> > > >> BTW, another thing that need to be integrated in order to make this >> > > stuff >> > > >> useful is the vmnet patch's, it is apple NAT for vms that allow >> > > >> guests >> > > to >> > > >> have networking... >> > > >> >> > > >> >> > > >> People can always use slirp (or tap with some more effort), so >> > > >> these >> > > >> patches are already a minimum viable feature and pretty close to >> > > >> being >> > > >> mergeable. But of course any other contribution is welcome! >> > > >> >> > > >> Paolo >> > > >> >> > > >> >> > > >> (altho that it come with a trick, without certificate it >> > > >> will require root permission, while hypverisor framework itself can >> > run >> > > >> without root) >> > > >> >> > > >> What do you guys think? >> > > >> >> > > >> >> > > >> > >> > > >> > Sergio worked on completing the QEMU port to >> > > >> > Hypervisor.framework. >> > The >> > > >> > hvf-all.c file that Daniel pointed out as v2-only is derived from >> > > >> kvm-all.c >> > > >> > and hax-all.c, and should be under v2-or-later license. The >> > > >> > others >> > > seem >> > > >> to >> > > >> > be either original or derived from Bochs, which is LGPL, so they >> > could >> > > >> be >> > > >> > LGPL or GPLv2+. >> > > >> > >> > > >> > Thanks, >> > > >> > >> > > >> > Paolo >> > > >> > >> > > >> > >> > > >> > There are benefits to having this code upstream. If they ever >> > > >> > want >> > to >> > > >> > rebase on qemu.git there will be less work for them. >> > > >> >> > > >> >> > > OK, >> > > >> > > >> > > > > >> > > >> > Stefan >> > > >> > >> > > >> > >> > > >> > >> > > >> >> > > >> >> > > >> >> > > > >> > > >> > > >> > > >> > >> > >> > >> >> > >