On 5 September 2017 at 00:46, Kamil Rytarowski <n...@gmx.com> wrote: > On 04.09.2017 11:32, Peter Maydell wrote: >> My assumption is that the issue is that Solaris doesn't >> have a -lutil (it's helpful to quote the linker or >> compiler error message for this kind of patch to clarify >> what the failure is that we're trying to fix). >> > > There is no libutil on SmartOS. > > I cannot provide any information about the proprietary Solaris here and > in next questions.
Yes; I was being a bit sloppy referring to all the forks of opensolaris as 'Solaris' there. Recent news suggests we don't need to consider support for the proprietary Solaris... >> It looks like we use libutil here for openpty, which >> is used in the test-char test. But the condition we're >> using in tests/Makefile.include isn't the same as the >> one we used to decide whether to add -lutil to the >> emulator binary link line, which is in configure: >> >> if test "$darwin" != "yes" -a "$mingw32" != "yes" -a "$solaris" != yes -a \ >> "$aix" != "yes" -a "$haiku" != "yes" ; then >> libs_softmmu="-lutil $libs_softmmu" >> fi >> >> So I think I'd prefer it if we have: >> * a configure test for "is openpty() in libutil" >> * use that to determine whether to add -lutil to >> libs_softmmu and to the libs for tests, rather than >> doing OS-specific tests >> > > This looks cleaner. I will go for it. Thanks. Remember that there are three cases to handle: * has openpty, don't need -lutil to get it (OSX is like this I think) * has openpty and you need -lutil (Linux) * has no openpty at all, use QEMU internal version (smartos) thanks -- PMM