On 25 October 2017 at 16:59, Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> wrote: > This enables them to be used outside of lance.c. > > Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> > CC: Jason Wang <jasow...@redhat.com>
> diff --git a/include/hw/net/lance.h b/include/hw/net/lance.h > new file mode 100644 > index 0000000..c112fbc > --- /dev/null > +++ b/include/hw/net/lance.h > @@ -0,0 +1,41 @@ > +/* > + * QEMU AMD PC-Net II (Am79C970A) emulation Filename says this is Lance ethernet, but the comment says it's PC-Net ? > +#define TYPE_LANCE "lance" > +#define SYSBUS_PCNET(obj) \ > + OBJECT_CHECK(SysBusPCNetState, (obj), TYPE_LANCE) It's a bit weird that the OBJECT_CHECK macro name and the state structure name don't line up with the device name, but this is just code motion so not a problem. Other than fixing the comment, Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> (In an ideal world pcnet.h would be in include/.) thanks -- PMM
