On 30 October 2017 at 13:10, Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> wrote: > On 26/10/17 11:12, Mark Cave-Ayland wrote: >> On 25/10/17 18:47, Peter Maydell wrote: >>> On 25 October 2017 at 16:59, Mark Cave-Ayland wrote: >>>> --- /dev/null >>>> +++ b/include/hw/net/lance.h >>>> @@ -0,0 +1,41 @@ >>>> +/* >>>> + * QEMU AMD PC-Net II (Am79C970A) emulation >>> >>> Filename says this is Lance ethernet, but the comment says it's PC-Net ? >> >> According to the datasheet for Am79C970A, the original Lance is an >> Am7990 device and the Am79C970A aka PCNet-PCI II as emulated by QEMU is >> register-compatible with it. >> >> I guess the comment above is more technically correct, but I'm happy to >> adjust it in my local tree if you still feel it needs to change?
I think we should have a comment that says what the file is for. Since this is a different file from pcnet.h, we should have a comment that isn't the same as the pcnet.h one. I don't particularly mind what it says, as long as it briefly explains what's in the file (and by implication what distinguishes things in this file from things in the other). thanks -- PMM
