On 08.11.2017 03:28, Philippe Mathieu-Daudé wrote: > Both are deprecated since 2.9.0 > > Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> > --- > hw/i386/pc_piix.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c > index f79d5cb694..c462b702ff 100644 > --- a/hw/i386/pc_piix.c > +++ b/hw/i386/pc_piix.c > @@ -941,6 +941,7 @@ static void pc_i440fx_0_11_machine_options(MachineClass > *m) > pc_i440fx_0_12_machine_options(m); > m->hw_version = "0.11"; > SET_MACHINE_COMPAT(m, PC_COMPAT_0_11); > + m->deprecated_reason = "Too old";
As Daniel already mentioned it, I'd also suggest to use a more helpful message instead (e.g. "Use a newer version of pc-i440fx instead" ?). > } > > DEFINE_I440FX_MACHINE(v0_11, "pc-0.11", pc_compat_0_13, > @@ -976,6 +977,7 @@ static void pc_i440fx_0_10_machine_options(MachineClass > *m) > pc_i440fx_0_11_machine_options(m); > m->hw_version = "0.10"; > SET_MACHINE_COMPAT(m, PC_COMPAT_0_10); > + m->deprecated_reason = "Too old"; I think you don't need the second hunk here since the function is calling pc_i440fx_0_11_machine_options(), too. Thomas