On Tue, Nov 07, 2017 at 11:28:28PM -0300, Philippe Mathieu-Daudé wrote:
> Deprecated since 2.9.0, guests should be able to use "pc" instead.
Isn't isapc important to allow QEMU to old operating systems that
predate the PCI era. I do recall seeing some messages about specific
cases where you cannot use the 'pc' machine type and we suggested
used of 'isapc' instead, but can't remember the exact details..
I know that's not a typical usecase for modern cloud / data center
virt, but it is interesting for usage of QEMU as a archeology tool,
so I'm loathe to see this removed unless it is demonstrably causing
an unacceptable maint burden to keep it.
> Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org>
> ---
> hw/i386/pc_piix.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
> index c462b702ff..df4669c6d3 100644
> --- a/hw/i386/pc_piix.c
> +++ b/hw/i386/pc_piix.c
> @@ -1114,6 +1114,7 @@ static void isapc_machine_options(MachineClass *m)
> pcmc->smbios_legacy_mode = true;
> pcmc->has_reserved_memory = false;
> m->default_cpu_type = X86_CPU_TYPE_NAME("486");
> + m->deprecated_reason = "Use the \"pc\" machine instead";
> }
>
> DEFINE_PC_MACHINE(isapc, "isapc", pc_init_isa,
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
