On 27 November 2017 at 14:52, Brad Smith <b...@comstyle.com> wrote: > On 11/27/2017 7:02 AM, Peter Maydell wrote: > >> On 26 November 2017 at 22:13, Brad Smith <b...@comstyle.com> wrote: >>> >>> Fix the curses probe with older ncurses (.e.g. 5.7, as used by OpenBSD). >>> >>> ncurses 5.7 requires _XOPEN_SOURCE_EXTENDED to be defined for WACS_* >>> constants. >> >> ncurses 5.7 was released in 2008 and is now 9 years old. Why >> is OpenBSD still using such an ancient version?
> Someone has to put the time and effort into updating it. Yes, but staying up to date with the libraries you ship is table stakes for being a serious OS. Having a sufficiently large and active developer community that this can happen is one of the things that separates "OS usable in production" from "hobby project, research project or just defunct OS" in my view. >> I'm a bit wary of this because we've found in the past that >> defining _XOPEN_* defines breaks compilation with some >> C libraries which assume that if you define _XOPEN_whatever >> it means "only that X/Open stuff and no OS-specific extras", >> and we depend on the OS-specific extras. >> >> That said, I did a test compile on OSX, which was the >> one that had trouble previously, so this may be OK. I think >> I'd rather leave it until after 2.11 releases, though. > The other option I was looking at was removing the add_wch() function > call from the probe as the rest of the curses code within QEMU compiles > Ok without _XOPEN_SOURCE_EXTENDED. That would break the fix made in commit 7c7030029626 -- we want to be sure we're actually getting a wide-character aware version of the headers, on systems which might have both the non-widechar and widechar headers in different places. thanks -- PMM
