On 26 November 2017 at 21:13, Brad Smith <b...@comstyle.com> wrote: > Fix the curses probe with older ncurses (.e.g. 5.7, as used by OpenBSD). > > ncurses 5.7 requires _XOPEN_SOURCE_EXTENDED to be defined for WACS_* > constants. > > Signed-off-by: Brad Smith <b...@comstyle.com> > > > diff --git a/configure b/configure > index 0c6e7572db..9715b9c2cc 100755 > --- a/configure > +++ b/configure > @@ -3186,7 +3186,7 @@ EOF > IFS=: > for curses_inc in $curses_inc_list; do > # Make sure we get the wide character prototypes > - curses_inc="-DNCURSES_WIDECHAR $curses_inc" > + curses_inc="-DNCURSES_WIDECHAR -D_XOPEN_SOURCE_EXTENDED $curses_inc" > IFS=: > for curses_lib in $curses_lib_list; do > unset IFS
Having thought about this a bit more, I think I'm definitely not happy with defining _XOPEN_SOURCE_EXTENDED by default for every host OS. I think we should either: (a) define it only for OpenBSD in the per-host case statement in configure, with a note that we're doing it to work around the supplied ncurses version being ancient (b) just say that if you want this optional QEMU feature you need a version of ncurses that was released this decade To be honest I'd favour (b): there are limits to how much we need to support adventures in retrocomputing. thanks -- PMM
