On Wed, 29 Nov 2017 16:54:30 +0100 David Hildenbrand <da...@redhat.com> wrote:
> >> diff --git a/target/s390x/mmu_helper.c b/target/s390x/mmu_helper.c > >> index 31e3f3f415..39da9aeef4 100644 > >> --- a/target/s390x/mmu_helper.c > >> +++ b/target/s390x/mmu_helper.c > >> @@ -22,6 +22,7 @@ > >> #include "internal.h" > >> #include "kvm_s390x.h" > >> #include "sysemu/kvm.h" > >> +#include "exec/exec-all.h" > >> #include "trace.h" > >> #include "hw/s390x/storage-keys.h" > >> > >> @@ -458,7 +459,7 @@ static int translate_pages(S390CPU *cpu, vaddr addr, > >> int nr_pages, > >> } > >> if (!address_space_access_valid(&address_space_memory, pages[i], > >> TARGET_PAGE_SIZE, is_write)) { > >> - program_interrupt(env, PGM_ADDRESSING, ILEN_AUTO); > >> + trigger_pgm_exception(env, PGM_ADDRESSING, ILEN_AUTO); > > > > Why did you change this? > > "For TCG, there was one case where a cpu loop exit was triggered. Fix > that up." > > Wasn't worth a separate patch :) Well, maybe it is, to avoid dumb questions :) > > > > >> return -EFAULT; > >> } > >> addr += TARGET_PAGE_SIZE;