Richard Henderson <richard.hender...@linaro.org> writes: > On 12/11/2017 04:56 AM, Alex Bennée wrote: >> +static inline float16 float16_set_sign(float16 a, int sign) >> +{ >> + return make_float16((float16_val(a) & 0x7fff) | (sign << 15)); >> +} >> + > > 1) Do we use this anywhere?
Yes in the target specific helpers > > 2) While this is probably in line with the other implementations, > but going to a more qemu-ish style this should use deposit32. OK, will do. > > Anyway, > > Reviewed-by: Richard Henderson <richard.hender...@linaro.org> > > > r~ -- Alex Bennée