On 01/08/2018 04:58 AM, Alex Bennée wrote: > > Alex Bennée <alex.ben...@linaro.org> writes: > >> Richard Henderson <richard.hender...@linaro.org> writes: >> >>> On 12/11/2017 04:56 AM, Alex Bennée wrote: >>>> +static inline float16 float16_set_sign(float16 a, int sign) >>>> +{ >>>> + return make_float16((float16_val(a) & 0x7fff) | (sign << 15)); >>>> +} >>>> + >>> >>> 1) Do we use this anywhere? >> >> Yes in the target specific helpers >> >>> >>> 2) While this is probably in line with the other implementations, >>> but going to a more qemu-ish style this should use deposit32. >> >> OK, will do. >> > > It turns out doing this unleashes a weird circular dependency at we need > qemu/bitops.h but that brings in host-utils.h and bswap.h which tries > to include softfloat.h again.
Bah. Just ignore this request for now then. For future cleanup, I'm sure that bswap.h includes softfloat.h for the float32/float64 typedefs. We should move those out somewhere else -- probably qemu/typedefs.h. Which probably drops the number of objects that depend on softfloat.h by a factor of 100. r~