On Mon, Jan 08, 2018 at 09:14:41AM +0000, Peter Maydell wrote: > On 21 December 2017 at 23:43, Michael S. Tsirkin <m...@redhat.com> wrote: > >> you also need to drop "hw/pci: remove obsolete PCIDevice->init()" > >> (applied in your tree as 18951fce55d5aa58cd1629b4cb704ee51bab4420) > >> else the not-yet-QOM'ified NVME won't work anymore. > > > > Done that too, thanks a lot > > Hi. I'm afraid this pullreq (merge of 880b1ff) has new runtime > errors from the clang sanitizer: > > /home/petmay01/linaro/qemu-for-merges/hw/net/net_tx_pkt.c:201:27: > runtime error: member access within misaligned address 0x55b4ffee8246 > for type 'struct ip_header', which requires 4 byte alignment > 0x55b4ffee8246: note: pointer points here > 01 00 00 00 45 00 01 a9 01 00 00 00 40 11 78 45 00 00 00 00 ff ff > ff ff 00 00 00 00 00 00 00 00 > ^ > /home/petmay01/linaro/qemu-for-merges/hw/net/net_tx_pkt.c:201:27: > runtime error: load of misaligned address 0x55b4ffee8246 for type > 'uint8_t' (aka 'unsigned char'), which requires 4 byte alignment > 0x55b4ffee8246: note: pointer points here > 01 00 00 00 45 00 01 a9 01 00 00 00 40 11 78 45 00 00 00 00 ff ff > ff ff 00 00 00 00 00 00 00 00 > ^ > /home/petmay01/linaro/qemu-for-merges/hw/net/net_tx_pkt.c:208:65: > runtime error: member access within misaligned address 0x55b4ffee8246 > for type 'struct ip_header', which requires 4 byte alignment > 0x55b4ffee8246: note: pointer points here > 01 00 00 00 45 00 01 a9 01 00 00 00 40 11 78 45 00 00 00 00 ff ff > ff ff 00 00 00 00 00 00 00 00 > ^ > /home/petmay01/linaro/qemu-for-merges/hw/net/net_tx_pkt.c:210:13: > runtime error: member access within misaligned address 0x55b4ffee8246 > for type 'struct ip_header', which requires 4 byte alignment > 0x55b4ffee8246: note: pointer points here > 01 00 00 00 45 00 01 a9 01 00 00 00 40 11 78 45 00 00 00 00 ff ff > ff ff 00 00 00 00 00 00 00 00 > ^ > /home/petmay01/linaro/qemu-for-merges/hw/net/net_tx_pkt.c:210:13: > runtime error: load of misaligned address 0x55b4ffee8246 for type > 'uint8_t' (aka 'unsigned char'), which requires 4 byte alignment > 0x55b4ffee8246: note: pointer points here > 01 00 00 00 45 00 01 a9 01 00 00 00 40 11 78 45 00 00 00 00 ff ff > ff ff 00 00 00 00 00 00 00 00 > ^ > > Sorry for the late report, I didn't quite have time > to process the pull before Christmas holidays. > > thanks > -- PMM
Hard to see how my pull could be doing this, but I'll try to bisect. BTW clang build prints lots of error around alignment for me. -- MST
