Hi, This series seems to have some coding style problems. See output below for more information:
Type: series Message-id: 20180111195225.4226-1-kw...@redhat.com Subject: [Qemu-devel] [RFC PATCH 00/10] x-blockdev-create for qcow2 === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 54f470b74b block: x-blockdev-create QMP command 1aab7a7129 qcow2: Use visitor for options in qcow2_create() a669aa74c7 util: Add qemu_opts_to_qdict_filtered() 9397f3fd59 qcow2: Handle full/falloc preallocation in qcow2_create2() f54ee96af1 qcow2: Use QCryptoBlockCreateOptions in qcow2_create2() b0955f8fa3 qcow2: Use BlockdevRef in qcow2_create2() 583499d48c qcow2: Pass BlockdevCreateOptions to qcow2_create2() 6c4762a900 qcow2: Let qcow2_create() handle protocol layer 715887c079 block/qapi: Add qcow2 create options to schema 84a5b6de96 block/qapi: Introduce BlockdevCreateOptions === OUTPUT BEGIN === Checking PATCH 1/10: block/qapi: Introduce BlockdevCreateOptions... Checking PATCH 2/10: block/qapi: Add qcow2 create options to schema... Checking PATCH 3/10: qcow2: Let qcow2_create() handle protocol layer... Checking PATCH 4/10: qcow2: Pass BlockdevCreateOptions to qcow2_create2()... ERROR: space prohibited after that '&' (ctx:WxW) #283: FILE: block/qcow2.c:3061: + .node = & (BlockdevRef) { ^ total: 1 errors, 0 warnings, 282 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 5/10: qcow2: Use BlockdevRef in qcow2_create2()... Checking PATCH 6/10: qcow2: Use QCryptoBlockCreateOptions in qcow2_create2()... Checking PATCH 7/10: qcow2: Handle full/falloc preallocation in qcow2_create2()... Checking PATCH 8/10: util: Add qemu_opts_to_qdict_filtered()... Checking PATCH 9/10: qcow2: Use visitor for options in qcow2_create()... ERROR: trailing whitespace #301: FILE: tests/qemu-iotests/049.out:109: +qemu-img: Invalid image size specified! You may use k, M, G, T, P or E suffixes for $ ERROR: trailing whitespace #310: FILE: tests/qemu-iotests/049.out:119: +qemu-img: Invalid image size specified! You may use k, M, G, T, P or E suffixes for $ total: 2 errors, 0 warnings, 313 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 10/10: block: x-blockdev-create QMP command... ERROR: "foo* bar" should be "foo *bar" #42: FILE: block.c:504: + BlockDriver* drv = bdrv_find_format(fmt); total: 1 errors, 0 warnings, 89 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@freelists.org