Hi, This series seems to have some coding style problems. See output below for more information:
Type: series Message-id: 1515788548-3570-1-git-send-email-jute...@microsoft.com Subject: [Qemu-devel] [PATCH 0/4] Implements the Windows Hypervisor Platform accelerator === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' c9a68bcd96 Add the WHPX acceleration enlightenments 03377875bf Introduce the WHPX impl 4fb340d015 Add the WHPX vcpu API a4e1eebb6a Add the Windows Hypervisor Platform accelerator. === OUTPUT BEGIN === Checking PATCH 1/4: Add the Windows Hypervisor Platform accelerator.... Checking PATCH 2/4: Add the WHPX vcpu API... ERROR: adding a line without newline at end of file #126: FILE: include/sysemu/whpx.h:40: +#endif /* QEMU_WHPX_H */ total: 1 errors, 0 warnings, 97 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 3/4: Introduce the WHPX impl... ERROR: do not use C99 // comments #71: FILE: target/i386/whpx-all.c:38: + // X64 General purpose registers ERROR: do not use C99 // comments #91: FILE: target/i386/whpx-all.c:58: + // X64 Segment registers ERROR: do not use C99 // comments #101: FILE: target/i386/whpx-all.c:68: + // X64 Table registers ERROR: do not use C99 // comments #105: FILE: target/i386/whpx-all.c:72: + // X64 Control Registers ERROR: do not use C99 // comments #112: FILE: target/i386/whpx-all.c:79: + // X64 Debug Registers ERROR: do not use C99 // comments #113: FILE: target/i386/whpx-all.c:80: +// WHvX64RegisterDr0, ERROR: do not use C99 // comments #114: FILE: target/i386/whpx-all.c:81: +// WHvX64RegisterDr1, ERROR: do not use C99 // comments #115: FILE: target/i386/whpx-all.c:82: +// WHvX64RegisterDr2, ERROR: do not use C99 // comments #116: FILE: target/i386/whpx-all.c:83: +// WHvX64RegisterDr3, ERROR: do not use C99 // comments #117: FILE: target/i386/whpx-all.c:84: +// WHvX64RegisterDr6, ERROR: do not use C99 // comments #118: FILE: target/i386/whpx-all.c:85: +// WHvX64RegisterDr7, ERROR: do not use C99 // comments #120: FILE: target/i386/whpx-all.c:87: + // X64 Floating Point and Vector Registers ERROR: do not use C99 // comments #148: FILE: target/i386/whpx-all.c:115: + // X64 MSRs ERROR: do not use C99 // comments #155: FILE: target/i386/whpx-all.c:122: +// WHvX64RegisterPat, ERROR: do not use C99 // comments #166: FILE: target/i386/whpx-all.c:133: + // Interrupt / Event Registers ERROR: do not use C99 // comments #167: FILE: target/i386/whpx-all.c:134: +// WHvRegisterPendingInterruption, ERROR: do not use C99 // comments #168: FILE: target/i386/whpx-all.c:135: +// WHvRegisterInterruptState, ERROR: do not use C99 // comments #169: FILE: target/i386/whpx-all.c:136: +// WHvRegisterPendingEvent0, ERROR: do not use C99 // comments #170: FILE: target/i386/whpx-all.c:137: +// WHvRegisterPendingEvent1 ERROR: do not use C99 // comments #171: FILE: target/i386/whpx-all.c:138: +// WHvX64RegisterDeliverabilityNotifications, ERROR: "foo* bar" should be "foo *bar" #199: FILE: target/i386/whpx-all.c:166: +static struct whpx_vcpu* get_whpx_vcpu(CPUState* cpu) ERROR: "(foo*)" should be "(foo *)" #201: FILE: target/i386/whpx-all.c:168: + return (struct whpx_vcpu*)cpu->hax_vcpu; WARNING: line over 80 characters #204: FILE: target/i386/whpx-all.c:171: +static WHV_X64_SEGMENT_REGISTER whpx_seg_q2h(const SegmentCache *qs, int v86, int r86) ERROR: do not use C99 // comments #232: FILE: target/i386/whpx-all.c:199: + //hs.Base &= 0xfffff; ERROR: "foo* bar" should be "foo *bar" #273: FILE: target/i386/whpx-all.c:240: +static void whpx_set_registers(CPUState* cpu) ERROR: "foo* bar" should be "foo *bar" #276: FILE: target/i386/whpx-all.c:243: + struct whpx_vcpu* vcpu = get_whpx_vcpu(cpu); ERROR: "(foo*)" should be "(foo *)" #277: FILE: target/i386/whpx-all.c:244: + struct CPUX86State* env = (CPUArchState*)(cpu->env_ptr); ERROR: do not use C99 // comments #356: FILE: target/i386/whpx-all.c:323: + //vcxt.values[idx].Fp.AsUINT128.High64 = env->fpregs[i].mmx.MMX_Q(1); WARNING: line over 80 characters #422: FILE: target/i386/whpx-all.c:389: + error_report("WHPX: Failed to set virtual processor context, hr=%08lx", hr); ERROR: "foo* bar" should be "foo *bar" #429: FILE: target/i386/whpx-all.c:396: +static void whpx_get_registers(CPUState* cpu) ERROR: "foo* bar" should be "foo *bar" #432: FILE: target/i386/whpx-all.c:399: + struct whpx_vcpu* vcpu = get_whpx_vcpu(cpu); ERROR: "(foo*)" should be "(foo *)" #433: FILE: target/i386/whpx-all.c:400: + struct CPUX86State* env = (CPUArchState*)(cpu->env_ptr); WARNING: line over 80 characters #448: FILE: target/i386/whpx-all.c:415: + error_report("WHPX: Failed to get virtual processor context, hr=%08lx", hr); ERROR: do not use C99 // comments #511: FILE: target/i386/whpx-all.c:478: + //env->fpregs[i].mmx.MMX_Q(1) = vcxt.values[idx].Fp.AsUINT128.High64; WARNING: line over 80 characters #575: FILE: target/i386/whpx-all.c:542: + WHV_EMULATOR_IO_ACCESS_INFO* IoAccess) ERROR: "foo* bar" should be "foo *bar" #575: FILE: target/i386/whpx-all.c:542: + WHV_EMULATOR_IO_ACCESS_INFO* IoAccess) ERROR: line over 90 characters #579: FILE: target/i386/whpx-all.c:546: + (uint8_t*)&IoAccess->Data, IoAccess->AccessSize, IoAccess->Direction); ERROR: "(foo*)" should be "(foo *)" #579: FILE: target/i386/whpx-all.c:546: + (uint8_t*)&IoAccess->Data, IoAccess->AccessSize, IoAccess->Direction); WARNING: line over 80 characters #584: FILE: target/i386/whpx-all.c:551: + WHV_EMULATOR_MEMORY_ACCESS_INFO* ma) ERROR: "foo* bar" should be "foo *bar" #584: FILE: target/i386/whpx-all.c:551: + WHV_EMULATOR_MEMORY_ACCESS_INFO* ma) WARNING: line over 80 characters #586: FILE: target/i386/whpx-all.c:553: + cpu_physical_memory_rw(ma->GpaAddress, ma->Data, ma->AccessSize, ma->Direction); WARNING: line over 80 characters #591: FILE: target/i386/whpx-all.c:558: + const WHV_REGISTER_NAME* RegisterNames, ERROR: "foo* bar" should be "foo *bar" #591: FILE: target/i386/whpx-all.c:558: + const WHV_REGISTER_NAME* RegisterNames, WARNING: line over 80 characters #593: FILE: target/i386/whpx-all.c:560: + WHV_REGISTER_VALUE* RegisterValues) ERROR: "foo* bar" should be "foo *bar" #593: FILE: target/i386/whpx-all.c:560: + WHV_REGISTER_VALUE* RegisterValues) ERROR: "(foo*)" should be "(foo *)" #597: FILE: target/i386/whpx-all.c:564: + CPUState* cpu = (CPUState*)ctx; WARNING: line over 80 characters #603: FILE: target/i386/whpx-all.c:570: + error_report("WHPX: Failed to get virtual processor registers, hr=%08lx", hr); WARNING: line over 80 characters #611: FILE: target/i386/whpx-all.c:578: + const WHV_REGISTER_NAME* RegisterNames, ERROR: "foo* bar" should be "foo *bar" #611: FILE: target/i386/whpx-all.c:578: + const WHV_REGISTER_NAME* RegisterNames, WARNING: line over 80 characters #613: FILE: target/i386/whpx-all.c:580: + const WHV_REGISTER_VALUE* RegisterValues) ERROR: "foo* bar" should be "foo *bar" #613: FILE: target/i386/whpx-all.c:580: + const WHV_REGISTER_VALUE* RegisterValues) ERROR: "(foo*)" should be "(foo *)" #617: FILE: target/i386/whpx-all.c:584: + CPUState* cpu = (CPUState*)ctx; WARNING: line over 80 characters #623: FILE: target/i386/whpx-all.c:590: + error_report("WHPX: Failed to set virtual processor registers, hr=%08lx", hr); WARNING: line over 80 characters #631: FILE: target/i386/whpx-all.c:598: + WHV_GUEST_VIRTUAL_ADDRESS Gva, WARNING: line over 80 characters #632: FILE: target/i386/whpx-all.c:599: + WHV_TRANSLATE_GVA_FLAGS TranslateFlags, ERROR: line over 90 characters #633: FILE: target/i386/whpx-all.c:600: + WHV_TRANSLATE_GVA_RESULT_CODE* TranslationResult, ERROR: "foo* bar" should be "foo *bar" #633: FILE: target/i386/whpx-all.c:600: + WHV_TRANSLATE_GVA_RESULT_CODE* TranslationResult, WARNING: line over 80 characters #634: FILE: target/i386/whpx-all.c:601: + WHV_GUEST_PHYSICAL_ADDRESS* Gpa) ERROR: "foo* bar" should be "foo *bar" #634: FILE: target/i386/whpx-all.c:601: + WHV_GUEST_PHYSICAL_ADDRESS* Gpa) ERROR: "(foo*)" should be "(foo *)" #638: FILE: target/i386/whpx-all.c:605: + CPUState* cpu = (CPUState*)ctx; ERROR: "foo* bar" should be "foo *bar" #663: FILE: target/i386/whpx-all.c:630: + WHV_VP_EXIT_CONTEXT* vp_ctx, ERROR: "foo* bar" should be "foo *bar" #664: FILE: target/i386/whpx-all.c:631: + uint8_t* bytes, uint8_t* count, ERROR: "foo* bar" should be "foo *bar" #714: FILE: target/i386/whpx-all.c:681: + struct whpx_vcpu* vcpu = get_whpx_vcpu(cpu); WARNING: line over 80 characters #738: FILE: target/i386/whpx-all.c:705: +static int whpx_handle_portio(CPUState *cpu, WHV_X64_IO_PORT_ACCESS_CONTEXT* ctx) ERROR: "foo* bar" should be "foo *bar" #741: FILE: target/i386/whpx-all.c:708: + struct whpx_vcpu* vcpu = get_whpx_vcpu(cpu); ERROR: "(foo*)" should be "(foo *)" #767: FILE: target/i386/whpx-all.c:734: + struct CPUX86State* env = (CPUArchState*)(cpu->env_ptr); ERROR: "foo* bar" should be "foo *bar" #787: FILE: target/i386/whpx-all.c:754: + struct whpx_vcpu* vcpu = get_whpx_vcpu(cpu); ERROR: "(foo*)" should be "(foo *)" #788: FILE: target/i386/whpx-all.c:755: + struct CPUX86State* env = (CPUArchState*)(cpu->env_ptr); WARNING: line over 80 characters #862: FILE: target/i386/whpx-all.c:829: + reg_values[reg_count].DeliverabilityNotifications.InterruptNotification = 1; ERROR: line over 90 characters #864: FILE: target/i386/whpx-all.c:831: + if (vcpu->window_registered != reg_values[reg_count].DeliverabilityNotifications.InterruptNotification) { ERROR: line over 90 characters #865: FILE: target/i386/whpx-all.c:832: + vcpu->window_registered = reg_values[reg_count].DeliverabilityNotifications.InterruptNotification; WARNING: line over 80 characters #876: FILE: target/i386/whpx-all.c:843: + error_report("WHPX: Failed o set interrupt state registers, hr=%08lx", hr); ERROR: "foo* bar" should be "foo *bar" #888: FILE: target/i386/whpx-all.c:855: + struct whpx_vcpu* vcpu = get_whpx_vcpu(cpu); ERROR: "(foo*)" should be "(foo *)" #889: FILE: target/i386/whpx-all.c:856: + struct CPUX86State* env = (CPUArchState*)(cpu->env_ptr); WARNING: line over 80 characters #902: FILE: target/i386/whpx-all.c:869: + error_report("WHPX: Failed to get interrupt state regusters, hr=%08lx", hr); ERROR: "(foo*)" should be "(foo *)" #930: FILE: target/i386/whpx-all.c:897: + struct CPUX86State* env = (CPUArchState*)(cpu->env_ptr); ERROR: "foo* bar" should be "foo *bar" #932: FILE: target/i386/whpx-all.c:899: + struct whpx_vcpu* vcpu = get_whpx_vcpu(cpu); ERROR: "foo* bar" should be "foo *bar" #976: FILE: target/i386/whpx-all.c:943: + struct whpx_vcpu* vcpu = get_whpx_vcpu(cpu); WARNING: line over 80 characters #1007: FILE: target/i386/whpx-all.c:974: + WHvCancelRunVirtualProcessor(whpx->partition, cpu->cpu_index, 0); WARNING: line over 80 characters #1014: FILE: target/i386/whpx-all.c:981: + error_report("WHPX: Failed to exec a virtual processor, hr=%08lx", hr); WARNING: line over 80 characters #1051: FILE: target/i386/whpx-all.c:1018: + error_report("WHPX: Unexpected VP exit code %d", vcpu->exit_ctx.ExitReason); WARNING: line over 80 characters #1083: FILE: target/i386/whpx-all.c:1050: +static void do_whpx_cpu_synchronize_post_init(CPUState *cpu, run_on_cpu_data arg) WARNING: line over 80 characters #1089: FILE: target/i386/whpx-all.c:1056: +static void do_whpx_cpu_synchronize_pre_loadvm(CPUState *cpu, run_on_cpu_data arg) ERROR: "foo* bar" should be "foo *bar" #1128: FILE: target/i386/whpx-all.c:1095: + struct whpx_vcpu* vcpu; ERROR: line over 90 characters #1140: FILE: target/i386/whpx-all.c:1107: + error_report("WHPX: Failed to setup instruction completion support, hr=%08lx", hr); WARNING: line over 80 characters #1147: FILE: target/i386/whpx-all.c:1114: + error_report("WHPX: Failed to create a virtual processor, hr=%08lx", hr); ERROR: "(foo*)" should be "(foo *)" #1156: FILE: target/i386/whpx-all.c:1123: + cpu->hax_vcpu = (struct hax_vcpu_state*)vcpu; ERROR: "foo* bar" should be "foo *bar" #1187: FILE: target/i386/whpx-all.c:1154: + struct whpx_vcpu* vcpu = get_whpx_vcpu(cpu); ERROR: "foo* bar" should be "foo *bar" #1205: FILE: target/i386/whpx-all.c:1172: +static void whpx_update_mapping(hwaddr start_pa, ram_addr_t size, void* host_va, ERROR: "foo* bar" should be "foo *bar" #1206: FILE: target/i386/whpx-all.c:1173: + int add, int rom, const char* name) ERROR: "(foo*)" should be "(foo *)" #1240: FILE: target/i386/whpx-all.c:1207: + (void*)start_pa, (void*)size, host_va, hr); ERROR: "(foo*)" should be "(foo *)" #1271: FILE: target/i386/whpx-all.c:1238: + whpx_update_mapping(start_pa, size, (void*)host_va, add, ERROR: line over 90 characters #1349: FILE: target/i386/whpx-all.c:1316: + hr = WHvGetCapability(WHvCapabilityCodeHypervisorPresent, &whpx_cap, sizeof(whpx_cap)); total: 68 errors, 25 warnings, 1399 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 4/4: Add the WHPX acceleration enlightenments... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@freelists.org