Hey Stefan, Thanks for the feedback. I really apologize I forgot to run the checkpath.pl script before submission. I have fixed up all the issues and will send them in patch v2 once I fixup the other feedback.
Thanks, Justin -----Original Message----- From: Stefan Weil [mailto:s...@weilnetz.de] Sent: Friday, January 12, 2018 1:57 PM To: Justin Terry (VM) <jute...@microsoft.com>; qemu-devel@nongnu.org Cc: pbonz...@redhat.com; r...@twiddle.net; ehabk...@redhat.com; crosthwaite.pe...@gmail.com Subject: Re: [Qemu-devel] [PATCH 0/4] Implements the Windows Hypervisor Platform accelerator Am 12.01.2018 um 21:22 schrieb Justin Terry (VM) via Qemu-devel: > Hello QEMU Community! > > Over the past few months the Hyper-V team at Microsoft has been > working hard on a new user-mode API for our hypervisor that will be > released as part of the upcoming SDK. This new API adds user-mode > capabilities to create and manage partitions at the hypervisor level, > configure memory mappings for the partition, and create and control execution > of virtual processors. > > With this new API we are now able to bring our hypervisor to the QEMU > community! The following patches implement the Windows Hypervisor > Platform accelerator (WHPX) for QEMU on Windows 10 hosts. > > When compiling QEMU for x86_64 passing the --enable-whpx flag will > compile the accelerator for use. At runtime using the '-accel whpx' > should see a significant performance improvement over emulation, much like > when using 'hax' > on Windows. > > Over the next few days the pre-release version of the documentation > for this new API will be visible at > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs. > microsoft.com%2Fen-us%2Fvirtualization&data=02%7C01%7Cjuterry%40microsoft.com%7Caf4261019804491eb49608d55a076ea4%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C1%7C636513910334166849&sdata=up%2FGCX06qE4RgerXWLJhxLsrspvzrvTZnY53nP4504c%3D&reserved=0 > under the 'Windows Hypervisor Platform' section. Here you will see the > requirements, API, and examples. > > Thank you for your feedback. > > Justin Terry (VM) (4): > Add the Windows Hypervisor Platform accelerator. > Add the WHPX vcpu API > Introduce the WHPX impl > Add the WHPX acceleration enlightenments > > accel/stubs/Makefile.objs | 9 +- > accel/stubs/whpx-stub.c | 48 ++ > configure | 48 +- > cpus.c | 66 ++- > include/sysemu/hw_accel.h | 13 + > include/sysemu/whpx.h | 40 ++ > qemu-options.hx | 8 +- > target/i386/Makefile.objs | 1 + > target/i386/helper.c | 2 +- > target/i386/whpx-all.c | 1395 > +++++++++++++++++++++++++++++++++++++++++++++ > 10 files changed, 1619 insertions(+), 11 deletions(-) create mode > 100644 accel/stubs/whpx-stub.c create mode 100644 > include/sysemu/whpx.h create mode 100644 target/i386/whpx-all.c Thank you for this contribution – I'll test it. The patches 2 and 3 fail the test with scripts/checkpatch.pl. Please fix that in the next iteration (maybe wait a little until there was more feedback). Regards, Stefan