[Qemu-devel] Re: [PATCH 2/3] piix: tag as not hotpluggable.

[Gerd Hoffmann]

diff --git a/hw/piix4.c b/hw/piix4.c
index 5489386..1678898 100644
--- a/hw/piix4.c
+++ b/hw/piix4.c
@@ -113,6 +113,7 @@ static PCIDeviceInfo piix4_info[] = {
          .qdev.desc    = "ISA bridge",
          .qdev.size    = sizeof(PCIDevice),
          .qdev.no_user = 1,
+        .qdev.no_hotplug = 1,
          .init         = piix4_initfn,
      },{
          /* end of list */

This one breaks the build for me.  The below seems to help - but begs
the question: was this tested?

Tested on x86.  piix4 chipset is used by hw/mips_malta.c, looks like I 
forgot to do a testbuild with all targets enabled :-(

diff --git a/hw/piix4.c b/hw/piix4.c
index 1678898..00da049 100644
--- a/hw/piix4.c
+++ b/hw/piix4.c
@@ -113,7 +113,7 @@ static PCIDeviceInfo piix4_info[] = {
          .qdev.desc    = "ISA bridge",
          .qdev.size    = sizeof(PCIDevice),
          .qdev.no_user = 1,
-        .qdev.no_hotplug = 1,
+        .no_hotplug = 1,
          .init         = piix4_initfn,
      },{
          /* end of list */

This is correct.  Do you just squash in the fix or do you want me respin 
the patch series?

cheers,
  Gerd