On Fri, Feb 9, 2018 at 3:35 AM, Richard Henderson < richard.hender...@linaro.org> wrote:
> On 02/07/2018 05:28 PM, Michael Clark wrote: > > QEMU currently implements IEEE 754-2008 minNum/maxNum. This patch adds > > support for IEEE 754-201x minimumNumber/maximumNumber which is required > > by the RISC-V port. > > > > minNum(x, y) is defined as > > - min(x, y) if neither is NaN > > - if one of x and y is a number and one is qNaN, return the number > > - if both are qNaN, or either is sNaN, return NaN > > > > minimumNumber(x, y) is defined as > > - min(x, y) if neither is NaN > > - if one of x and y is a number and one is qNaN or sNaN, return the > number > > - if both are NaN, return the number > > > > Both functions signal the invalid exception on sNaN inputs. > > > > Signed-off-by: Michael Clark <m...@sifive.com> > > --- > > Thanks for the description of the function. We've got a reorg of softfloat > pending at the moment; I'd want to defer this patch until that set has > landed. > Noted. We should also add a mention of minimumNumber/maximumNumber to the preceeding comment, which isn't in the current version of the patch. e.g. * minimumnumber() and maximumnumber() functions correspond to minimumNumber() * and maximumNumber() from the IEEE-754 201x specification.