On 02/08/2018 09:31 AM, Alex Bennée wrote: > case 0x2f: /* FMINP */ > - /* FP op, size[0] is 32 or 64 bit */ > + /* FP op, size[0] is 32 or 64 bit*/
If you're going to frob the whitespace, you might as well update to include the fact that it can be 16 bit too... > if (!u) { > - unallocated_encoding(s); > - return; > + if (!arm_dc_feature(s, ARM_FEATURE_V8_FP16)) { > + unallocated_encoding(s); > + return; > + } else { > + size = MO_16; > + } > + } else { > + size = extract32(size, 0, 1) ? MO_64 : MO_32; > } Otherwise, Reviewed-by: Richard Henderson <richard.hender...@linaro.org> r~