On Tue, 02/13 18:09, Daniel P. Berrangé wrote: > On Tue, Feb 13, 2018 at 05:34:25PM +0000, Stefan Hajnoczi wrote: > > From: Fam Zheng <f...@redhat.com> > > > > git-publish [1] is a convenient tool to send patches and has been > > popular among QEMU developers. Recently it has been made available in > > Fedora official repo thanks to Stefan's work. > > > > One nice feature of the tool is a per-project configuration with > > profiles, especially in which the cccmd option is a handy method to > > create the Cc list. > > > > [1]: https://github.com/stefanha/git-publish > > > > Signed-off-by: Fam Zheng <f...@redhat.com> > > Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com> > > Message-id: 20180205054725.25634-2-f...@redhat.com > > Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> > > --- > > .gitpublish | 58 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 58 insertions(+) > > create mode 100644 .gitpublish > > > > diff --git a/.gitpublish b/.gitpublish > > new file mode 100644 > > index 0000000000..ed48f6e52c > > --- /dev/null > > +++ b/.gitpublish > > @@ -0,0 +1,58 @@ > > +# > > +# Common git-publish profiles that can be used to send patches to QEMU > > upstream. > > +# > > +# See https://github.com/stefanha/git-publish for more information > > +# > > +[gitpublishprofile "default"] > > +base = master > > +prefix = PATCH > > +to = qemu-devel@nongnu.org > > +cccmd = scripts/get_maintainer.pl --noroles --norolestats --nogit > > --nogit-fallback 2>/dev/null > > + > > +[gitpublishprofile "rfc"] > > +base = master > > +prefix = RFC PATCH > > +to = qemu-devel@nongnu.org > > +cccmd = scripts/get_maintainer.pl --noroles --norolestats --nogit > > --nogit-fallback 2>/dev/null > > + > > +[gitpublishprofile "stable"] > > +base = master > > +prefix = PATCH > > +to = qemu-devel@nongnu.org > > +cc = qemu-sta...@nongnu.org > > +cccmd = scripts/get_maintainer.pl --noroles --norolestats --nogit > > --nogit-fallback 2>/dev/null > > + > > +[gitpublishprofile "trivial"] > > +base = master > > +prefix = PATCH > > +to = qemu-devel@nongnu.org > > +cc = qemu-triv...@nongnu.org > > +cccmd = scripts/get_maintainer.pl --noroles --norolestats --nogit > > --nogit-fallback 2>/dev/null > > + > > +[gitpublishprofile "block"] > > +base = master > > +prefix = PATCH > > +to = qemu-devel@nongnu.org > > +cc = qemu-bl...@nongnu.org > > +cccmd = scripts/get_maintainer.pl --noroles --norolestats --nogit > > --nogit-fallback 2>/dev/null > > Why is a custom entry needed for block here (and other things > below). Won't running get_maintainer.pl already correctly > report when a patch needs cc'ing to qemu-bl...@nongnu.org > based on MAINTAINER rules ?
Yeah, dropping them should be fine. What do you think, Stefan? Fam
